-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure /config/config.R
#17
Conversation
Suggestions added by Chris for the status-board to directly fetch our local server over docker instead of `141.142.216.168` which was a virtual machine at NCSA that’s apparently down
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than swapping one hard-coded URL for a different hard-coded URL, could we make the URL a variable that we define once and then use everywhere?
Yes. I have several ideas in my mind for that.
library("statusboard")
statusboard::run_app() --host {host_url} We will the
library("statusboard")
statusboard::run_app()
> Enter your host_url (default : https://pecan.localhost) : Which one do you find the most suitable for this? |
I don't think you want to rely on host_url being set interactively, that could put limitations on where/how the app is deployed. For this PR I think it's fine to just define the variable host_url in one place that's clearly documented, either in the script itself or in a simple config file. I'm also fine with https://pecan.localhost being the default. |
Changes made :
|
Hey @mdietze . Ready to be merged ! |
Suggestions initially added by @infotroph for the
pecan-status-board
to directly fetch our local dockerised server (http://pecan.localhost/
) instead ofhttp://141.142.216.168/
which was a virtual machine at NCSA that’s apparently down.